[core] Do not clean base and delta manifests in ChangelogDeletion#7429
Open
tsreaper wants to merge 3 commits intoapache:masterfrom
Open
[core] Do not clean base and delta manifests in ChangelogDeletion#7429tsreaper wants to merge 3 commits intoapache:masterfrom
tsreaper wants to merge 3 commits intoapache:masterfrom
Conversation
tsreaper
force-pushed
the
changelog-expire
branch
from
5354456 to
6c72eba
Compare
JingsongLi
reviewed
Mar 17, 2026
| cleanUnusedManifestList(changelog.deltaManifestList(), skippingSet); | ||
| } | ||
| if (manifestList.exists(changelog.baseManifestList())) { | ||
| cleanUnusedManifestList(changelog.baseManifestList(), skippingSet); |
Contributor
There was a problem hiding this comment.
Why clean base here, it is very dangerous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently,
ChangelogDeletionwill clean base and delta manifests. However these manifests are also cleaned inSnapshotDeletion.Consider the following scenario:
snapshot-1is changed tochangelog-1. However due to some issue, its base and delta manifests are not cleaned.snapshot-1is changed tochangelog-2. Its base and delta manifests are cleaned.changelog-1, aschangelog-2has no manifests, all manifests inchangelog-1will be cleaned, even if they're still in use by later snapshots.This PR fixes the bug by not cleaning base and delta manifests in
ChangelogDeletion.Tests
ChangelogExpireTest#testChangelogExpireWithUncleanedManifestLists.API and Format
No format changes.
Documentation
No new feature.